Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update css file names, fix documentation #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 14, 2021
Merged

Update css file names, fix documentation #857

merged 8 commits into from
Sep 14, 2021

Conversation

lucyleeow
Copy link
Contributor

@lucyleeow lucyleeow commented Sep 12, 2021 •
edited
Loading

Follows from #845

Prepends 'sg_' to all our css file names.
Fixes a circle ci error.

lucyleeow
lucyleeow commented Sep 12, 2021
View reviewed changes
doc/advanced.rst
Comment on lines +410 to +411
this can be found in `PR #845
<https://github.com/sphinx-gallery/sphinx-gallery/pull/845>`_.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not 100% about adding reference to the issue here, happy to change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to have these in the doc

@lucyleeow
Copy link
Contributor Author

lucyleeow commented Sep 12, 2021 •
edited
Loading

Got this error in circle Ci, update libraries:

Get:1 http://deb.debian.org/debian buster InRelease [122 kB]
Get:2 http://security.debian.org/debian-security buster/updates InRelease [65.4 kB]
Get:3 http://deb.debian.org/debian buster-updates InRelease [51.9 kB]
Reading package lists... Done      
E: Repository 'http://security.debian.org/debian-security buster/updates InRelease' changed its 'Suite' value from 'stable' to 'oldstable'
N: This must be accepted explicitly before updates for this repository can be applied. See apt-secure(8) manpage for details.
N: Repository 'http://deb.debian.org/debian buster InRelease' changed its 'Version' value from '10.5' to '10.10'
E: Repository 'http://deb.debian.org/debian buster InRelease' changed its 'Suite' value from 'stable' to 'oldstable'
N: This must be accepted explicitly before updates for this repository can be applied. See apt-secure(8) manpage for details.
E: Repository 'http://deb.debian.org/debian buster-updates InRelease' changed its 'Suite' value from 'stable-updates' to 'oldstable-updates'
N: This must be accepted explicitly before updates for this repository can be applied. See apt-secure(8) manpage for details.

copied solution from here: https://stackoverflow.com/questions/68802802/repository-http-security-debian-org-debian-security-buster-updates-inrelease

Python Nightly seems to have a Sphinx related error. Will look into it. nevermind that fixed itself.

@lucyleeow
Copy link
Contributor Author

ping @larsoner this is ready for review.

larsoner
larsoner reviewed Sep 13, 2021
View reviewed changes
.circleci/config.yml Outdated
@@ -9,7 +9,7 @@ jobs:
- run:
name: Update libraries
command: |
sudo apt-get update
sudo apt-get --allow-releaseinfo-change update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this elsewhere recently by changing to sudo apt I think, but this is also fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to sudo apt.

larsoner
larsoner approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait a couple of days in case @mgeier has comments

sphinx_gallery/gen_gallery.py
Comment on lines -39 to +40
_KNOWN_CSS = ('gallery', 'gallery-binder', 'gallery-dataframe',
'gallery-rendered-html')
_KNOWN_CSS = ('sg_gallery', 'sg_gallery-binder', 'sg_gallery-dataframe',
'sg_gallery-rendered-html')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgeier in #601 you added load_style to just add the sphinx-gallery style sheets, I just want to make sure that renaming these won't break functionality for you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @larsoner for thinking about this!

The change works perfectly fine with nbsphinx, since the load_style sub-module has been correctly updated.
The actual file name doesn't matter for my use case.

doc/advanced.rst
Comment on lines +410 to +411
this can be found in `PR #845
<https://github.com/sphinx-gallery/sphinx-gallery/pull/845>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to have these in the doc

@lucyleeow lucyleeow merged commit 327eb1f into sphinx-gallery:master Sep 14, 2021
@lucyleeow
Copy link
Contributor Author

lucyleeow commented Sep 14, 2021 •
edited
Loading

Thanks @larsoner and @mgeier

@lucyleeow lucyleeow deleted the css branch September 14, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeier mgeier mgeier left review comments

@larsoner larsoner larsoner approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucyleeow @mgeier @larsoner