Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

fibonacci1729
Copy link
Collaborator

This PR ensures that each source field and depenency source specified in a Spin component is a valid Wasm binary.

Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual code that does the actual thing looks fine, but I did have a good old moan about the tests I'm afraid. Not a blocker but would be nice to tighten them up if you have the bandwidth.

Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Just a couple of extremely non-blocking suggestions, feel free to ignore

@fibonacci1729 fibonacci1729 enabled auto-merge (squash) July 22, 2025 22:35
@fibonacci1729 fibonacci1729 merged commit eb9634c into spinframework:main Jul 22, 2025
17 checks passed
macro_rules! make_locked {
($source:literal, $($dep_name:literal=$dep_path:literal),*) => {
from_json!({
"id": "jiggs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate users are passing .wasm files during spin registry push
2 participants