-
Notifications
You must be signed in to change notification settings - Fork 289
Update Go documentation #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
48bfa14
to
7c17585
Compare
This looks great, thank you! Could you please rebase (keep the useful commits), sign-off, and add a commit GPG signature? Thank you! |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks!
(by the way, I fixed one tiny typo rather than going back to you again - hope that was okay)
I'm really sorry about this but it looks like the GPG signatures are not working yet - our main branch is set up to need verified signatures which should show up like this: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification describes how to do this - if your commits are already GPG signed it may just be a matter of adding the key to your GitHub account, otherwise might need to run through the whole workflow. Thanks for your patience! |
Signed-off-by: sealmove <[email protected]>
@itowlson I got my git setting straight! Thanks for the instructions. I squashed everything into one verified commit. |
Before merging, please check if there are other outdated examples or documentation in general.