Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sealmove
Copy link
Contributor

Before merging, please check if there are other outdated examples or documentation in general.

@sealmove sealmove force-pushed the go-docs branch 2 times, most recently from 48bfa14 to 7c17585 Compare August 26, 2022 09:35
@radu-matei
Copy link
Member

This looks great, thank you!

Could you please rebase (keep the useful commits), sign-off, and add a commit GPG signature?

Thank you!

@sealmove
Copy link
Contributor Author

sealmove commented Aug 31, 2022

Could you please rebase (keep the useful commits), sign-off, and add a commit GPG signature?

done

Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

(by the way, I fixed one tiny typo rather than going back to you again - hope that was okay)

@itowlson
Copy link
Collaborator

itowlson commented Sep 1, 2022

I'm really sorry about this but it looks like the GPG signatures are not working yet - our main branch is set up to need verified signatures which should show up like this:

image

https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification describes how to do this - if your commits are already GPG signed it may just be a matter of adding the key to your GitHub account, otherwise might need to run through the whole workflow.

Thanks for your patience!

@sealmove
Copy link
Contributor Author

sealmove commented Sep 2, 2022

@itowlson I got my git setting straight! Thanks for the instructions. I squashed everything into one verified commit.

@radu-matei radu-matei merged commit c3bbfeb into spinframework:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants