feat: add support to override Spin compatibility checks for plugins #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3559d04 to
bdb2bdb
Compare
itowlson
approved these changes
Oct 2, 2022
| "Could not parse manifest compatibility version {} as valid semver", | ||
| &supported_on, | ||
| ) | ||
| format!("Could not parse manifest compatibility version {supported_on} as valid semver") |
There was a problem hiding this comment.
Suggestion, though probably an irrelevant one... if override_compatibility_check is set, a parse error should not be fatal (the user has already said they don't care about versions). That said, it's hard to imagine how any plugin with a broken version spec gets this far!
Signed-off-by: Kate Goldenring <[email protected]>
bdb2bdb to
5c44af7
Compare
karthik2804
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin plugins state which versions of Spin they are compatible with in their plugin manifest. Currently, Spin checks if the plugin is compatible before allowing it to be installed or executed. If incompatible, the operation fails. This allows overriding that failure with an
--override-compatibility-checkflag. When specified during Spin plugin installs, upgrades and executions, the action will continue even if the plugin is incompatible with the current version of Spin.More context on the decision to add this override can be found in this thread: #735 (comment)