Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Swap wget for curl to be consistent with docs #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2022
Merged

Swap wget for curl to be consistent with docs #785

merged 2 commits into from
Sep 28, 2022

Conversation

ipedrazas
Copy link
Contributor

The quickstart has install instructions using curl, however, the install script is using wget.

Quickstart:

curl https://spin.fermyon.dev/downloads/install.sh | bash

Install script:

# Download file, exit if not found - e.g. version does not exist
fancy_print 0 "Step 1: Downloading: ${URL}"
wget -q $URL || (fancy_print 1 "The requested file does not exist: ${FILE}"; exit 1)
fancy_print 0 "Done...\n"

This PR replaces the wget instructions for the equivalent curl ones, to keep the tool used in the documentation and in the script consistent.

@ipedrazas ipedrazas force-pushed the chrore/swap-wget-curl branch from bbb6e1c to dfb1b36 Compare September 23, 2022 14:02
mikkelhegn
mikkelhegn suggested changes Sep 26, 2022
View reviewed changes
@ipedrazas
chore add fail flag
c0b2c04 
Signed-off-by: Ivan Pedrazas <[email protected]>
@mikkelhegn
Copy link
Contributor

Cool - thx!

@mikkelhegn mikkelhegn merged commit 8a2a6d3 into spinframework:main Sep 28, 2022
@ipedrazas ipedrazas deleted the chrore/swap-wget-curl branch September 28, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikkelhegn mikkelhegn mikkelhegn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipedrazas @mikkelhegn