More flexibility and guidance in the spin new experience
#807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
reviewed
Oct 5, 2022
src/commands/new.rs
Outdated
| let mut input = dialoguer::Input::<String>::new(); | ||
| input.with_prompt("Enter a name for your new project"); | ||
| let result = input.interact_text()?; | ||
| Ok(result) |
There was a problem hiding this comment.
I wonder if this should loop on empty input, printing something like:
Project name is required. (ctrl-c to cancel)
There was a problem hiding this comment.
Looks like the dialoguer component already rejects empty input, though it does accept "all spaces." (Which, to my surprise, we actually cope with.) I'll trim and loop for that case just in case (though realistically we're more interested in protecting against Murphy vs. against Machiavelli).
kate-goldenring
approved these changes
Oct 5, 2022
Signed-off-by: itowlson <[email protected]>
0141ea2 to
baeb6be
Compare
fibonacci1729
approved these changes
Oct 6, 2022
lann
approved these changes
Oct 6, 2022
radu-matei
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a developer new to Spin and wanting to create an application needs to manually install templates, and needs to know the ID of the template they want to use.
This PR makes it optional to pass the template ID on the command line. If the template ID is omitted,
spin newprompts with a list of installed templates:Additionally, if
spin newneeds to prompt but no templates are installed,spin newoffers to install the "default" set:If the template ID and project name are passed on the command line,
spin newcontinues to behave as it did before.Note: Because the ID and project name are positional args, this PR necessarily also makes the name optional. It will be prompted for if not provided. This creates an additional experience of
spin new <template_id>where you will be prompted for the name but not the template. I don't think this is vastly valuable but it's benign so I haven't worried about it.Signed-off-by: itowlson [email protected]