Break login into smaller functions #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <[email protected]>
Signed-off-by: itowlson <[email protected]>
0126cbc to
577b6a9
Compare
|
I was doing some further testing on this and hit a display issue with interactive prompts (prompts weren't displaying until a newline character arrived). I've included a fix for that here, as a separate commit, but can split it into a separate PR if we want. |
Signed-off-by: itowlson <[email protected]>
|
I'm afraid I ran into another one, where the Bindle URL was working if provided via the CLI or env vars (which, realistically, is how everyone does it), but if you were going through the interactive prompt process, we didn't ask for it, leading to failure at deployment time. Again, I've bundled it in here, but can move it to a distinct PR if preferred. |
radu-matei
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have no observable effect on the UX* - it just breaks up the LoginCommand::run() function into smaller bits that hopefully make the various flows more visible and tractable.
*oh okay, it does have one observable effect - the--get-device-codeand--check-device-codearguments now override--auth-methodwhereas previously it was the other way round - but mixing those flags is a bit iffy anywaySigned-off-by: itowlson [email protected]