Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve deployment experience #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2022
Merged

Improve deployment experience #824

merged 3 commits into from
Oct 18, 2022

Conversation

itowlson
Copy link
Collaborator

This PR:

  • modifies the sloth warnings to be "checking status" (for the Hippo health check) and "uploading application" (for Bindle) instead of warning about a slow response
  • adds the "wait for application ready" UI when deploying using a GH token, so the user is less likely to see the 404 of application not ready

It also removes what seems to have been a duplicate sloth warning for the bindle upload, probably a spurious leftover from an earlier merge.

@mikkelhegn
Copy link
Contributor

mikkelhegn commented Oct 18, 2022 •
edited
Loading

This experience is much better now - Thx @itowlson!

@itowlson itowlson merged commit 14020b9 into spinframework:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@radu-matei radu-matei radu-matei approved these changes

@bacongobbler bacongobbler Awaiting requested review from bacongobbler

+1 more reviewer

@karthik2804 karthik2804 karthik2804 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@itowlson @mikkelhegn @endocrimes @radu-matei @karthik2804