fix: assertion should not fail if input was empty string#36
Merged
Conversation
08c8395 to
0e0b518
Compare
danking
approved these changes
Sep 17, 2024
danking
left a comment
Member
There was a problem hiding this comment.
No bytes is the best amount of bytes.
Merged
a10y
pushed a commit
that referenced
this pull request
Sep 17, 2024
## 🤖 New release * `fsst-rs`: 0.4.1 -> 0.4.2 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.2](v0.4.1...v0.4.2) - 2024-09-17 ### Fixed - search for first non-empty chunk ([#35](#35)) - docs first3 ([#33](#33)) ### Other - Assertion should allow empty compression ([#36](#36)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
a1412744807
added a commit
to a1412744807/rs-fsst
that referenced
this pull request
Oct 27, 2025
## 🤖 New release * `fsst-rs`: 0.4.1 -> 0.4.2 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.2](spiraldb/fsst@v0.4.1...v0.4.2) - 2024-09-17 ### Fixed - search for first non-empty chunk ([#35](spiraldb/fsst#35)) - docs first3 ([#33](spiraldb/fsst#33)) ### Other - Assertion should allow empty compression ([#36](spiraldb/fsst#36)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Goodbai-1206
added a commit
to Goodbai-1206/fsst-rs
that referenced
this pull request
Oct 29, 2025
## 🤖 New release * `fsst-rs`: 0.4.1 -> 0.4.2 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.2](spiraldb/fsst@v0.4.1...v0.4.2) - 2024-09-17 ### Fixed - search for first non-empty chunk ([#35](spiraldb/fsst#35)) - docs first3 ([#33](spiraldb/fsst#33)) ### Other - Assertion should allow empty compression ([#36](spiraldb/fsst#36)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
akkjs887
added a commit
to akkjs887/rt-rsst
that referenced
this pull request
Oct 29, 2025
## 🤖 New release * `fsst-rs`: 0.4.1 -> 0.4.2 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.2](spiraldb/fsst@v0.4.1...v0.4.2) - 2024-09-17 ### Fixed - search for first non-empty chunk ([#35](spiraldb/fsst#35)) - docs first3 ([#33](spiraldb/fsst#33)) ### Other - Assertion should allow empty compression ([#36](spiraldb/fsst#36)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yelirekhmon
added a commit
to yelirekhmon/fstrs
that referenced
this pull request
Oct 30, 2025
## 🤖 New release * `fsst-rs`: 0.4.1 -> 0.4.2 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.2](spiraldb/fsst@v0.4.1...v0.4.2) - 2024-09-17 ### Fixed - search for first non-empty chunk ([#35](spiraldb/fsst#35)) - docs first3 ([#33](spiraldb/fsst#33)) ### Other - Assertion should allow empty compression ([#36](spiraldb/fsst#36)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lower-level methods support empty, but this assertion on the wrapper was causing failures when empty plaintext provided