Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Assert enough room in decoded buffer#79

Merged
gatesn merged 4 commits into
developfrom
ngates/assert-oob
Mar 12, 2025
Merged

Assert enough room in decoded buffer#79
gatesn merged 4 commits into
developfrom
ngates/assert-oob

Conversation

@gatesn

@gatesn gatesn commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

C++ version includes this check too posOut+32 <= size:
https://github.com/carlopi/duckdb/blob/b2f613b238a9ca7b739b76dac6fd8dd551dea817/third_party/fsst/fsst.h#L177

We should not trust that the caller has reserved sufficient space.

@gatesn gatesn requested a review from 0ax1 March 12, 2025 10:09
@codspeed-hq

codspeed-hq Bot commented Mar 12, 2025 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #79 will degrade performances by 14.02%

Comparing ngates/assert-oob (6ee86ae) with develop (6ae819b)

Summary

❌ 4 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ decompress 5.7 ms 6.5 ms -13%
❌ decompress 15.1 ms 17.5 ms -13.49%
❌ decompress 8.2 ms 9.5 ms -14.02%
❌ compress-hashtab 364.7 ns 423.1 ns -13.79%

0ax1
0ax1 approved these changes Mar 12, 2025
View reviewed changes

@0ax1 0ax1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robert3005

robert3005 commented Mar 12, 2025

Copy link
Copy Markdown
Member

Can you elaborate a bit as to why we shouldn't?

@gatesn gatesn enabled auto-merge (squash) March 12, 2025 11:54
@gatesn gatesn merged commit 6f58549 into develop Mar 12, 2025
@gatesn gatesn deleted the ngates/assert-oob branch March 12, 2025 12:04
@github-actions github-actions Bot mentioned this pull request Mar 12, 2025
Merged
gatesn pushed a commit that referenced this pull request Mar 12, 2025
@github-actions
chore: release v0.5.1 (#72)
3fce913 
## 🤖 New release

* `fsst-rs`: 0.5.0 -> 0.5.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.5.1](v0.5.0...v0.5.1) -
2025-03-12

### Other

- Decompress in 8-byte blocks
([#82](#82))
- *(deps)* lock file maintenance
([#83](#83))
- Assert enough room in decoded buffer
([#79](#79))
- *(deps)* update rust crate criterion to v2.9.1
([#80](#80))
- *(deps)* update mozilla-actions/sccache-action action to v0.0.8
([#78](#78))
- *(deps)* lock file maintenance
([#77](#77))
- Add codspeed ([#76](#76))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
a1412744807 added a commit to a1412744807/rs-fsst that referenced this pull request Oct 27, 2025
@a1412744807 @github-actions
chore: release v0.5.1 (#72)
c05624d 
## 🤖 New release

* `fsst-rs`: 0.5.0 -> 0.5.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.5.1](spiraldb/fsst@v0.5.0...v0.5.1) -
2025-03-12

### Other

- Decompress in 8-byte blocks
([#82](spiraldb/fsst#82))
- *(deps)* lock file maintenance
([#83](spiraldb/fsst#83))
- Assert enough room in decoded buffer
([#79](spiraldb/fsst#79))
- *(deps)* update rust crate criterion to v2.9.1
([#80](spiraldb/fsst#80))
- *(deps)* update mozilla-actions/sccache-action action to v0.0.8
([#78](spiraldb/fsst#78))
- *(deps)* lock file maintenance
([#77](spiraldb/fsst#77))
- Add codspeed ([#76](spiraldb/fsst#76))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Goodbai-1206 added a commit to Goodbai-1206/fsst-rs that referenced this pull request Oct 29, 2025
@Goodbai-1206 @github-actions
chore: release v0.5.1 (#72)
d77bd38 
## 🤖 New release

* `fsst-rs`: 0.5.0 -> 0.5.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.5.1](spiraldb/fsst@v0.5.0...v0.5.1) -
2025-03-12

### Other

- Decompress in 8-byte blocks
([#82](spiraldb/fsst#82))
- *(deps)* lock file maintenance
([#83](spiraldb/fsst#83))
- Assert enough room in decoded buffer
([#79](spiraldb/fsst#79))
- *(deps)* update rust crate criterion to v2.9.1
([#80](spiraldb/fsst#80))
- *(deps)* update mozilla-actions/sccache-action action to v0.0.8
([#78](spiraldb/fsst#78))
- *(deps)* lock file maintenance
([#77](spiraldb/fsst#77))
- Add codspeed ([#76](spiraldb/fsst#76))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
akkjs887 added a commit to akkjs887/rt-rsst that referenced this pull request Oct 29, 2025
@akkjs887 @github-actions
chore: release v0.5.1 (#72)
497d030 
## 🤖 New release

* `fsst-rs`: 0.5.0 -> 0.5.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.5.1](spiraldb/fsst@v0.5.0...v0.5.1) -
2025-03-12

### Other

- Decompress in 8-byte blocks
([#82](spiraldb/fsst#82))
- *(deps)* lock file maintenance
([#83](spiraldb/fsst#83))
- Assert enough room in decoded buffer
([#79](spiraldb/fsst#79))
- *(deps)* update rust crate criterion to v2.9.1
([#80](spiraldb/fsst#80))
- *(deps)* update mozilla-actions/sccache-action action to v0.0.8
([#78](spiraldb/fsst#78))
- *(deps)* lock file maintenance
([#77](spiraldb/fsst#77))
- Add codspeed ([#76](spiraldb/fsst#76))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yelirekhmon added a commit to yelirekhmon/fstrs that referenced this pull request Oct 30, 2025
@yelirekhmon @github-actions
chore: release v0.5.1 (#72)
01dc71f 
## 🤖 New release

* `fsst-rs`: 0.5.0 -> 0.5.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.5.1](spiraldb/fsst@v0.5.0...v0.5.1) -
2025-03-12

### Other

- Decompress in 8-byte blocks
([#82](spiraldb/fsst#82))
- *(deps)* lock file maintenance
([#83](spiraldb/fsst#83))
- Assert enough room in decoded buffer
([#79](spiraldb/fsst#79))
- *(deps)* update rust crate criterion to v2.9.1
([#80](spiraldb/fsst#80))
- *(deps)* update mozilla-actions/sccache-action action to v0.0.8
([#78](spiraldb/fsst#78))
- *(deps)* lock file maintenance
([#77](spiraldb/fsst#77))
- Add codspeed ([#76](spiraldb/fsst#76))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0ax1 0ax1 0ax1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gatesn @robert3005 @0ax1