Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added setup_logging() method in splunklib for logging and updated README.md files #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2022
Merged

added setup_logging() method in splunklib for logging and updated README.md files #437

merged 3 commits into from
Mar 4, 2022

Conversation

akaila-splunk
Copy link
Contributor

  • Used module-specific logger in splunklib code instead of root logger
  • Added new setup_logging() method in splunklib to set logging level, log format(optional) and date format(optional)
  • Updated REAME.md file with details of setup_logging() method
  • Updated searchcommands_app/README.md file with some details of logging.conf file and how to see debug logs
  • Here is an example of log message,
Before code change:
	DEBUG:root:Log message
After code change:
	2022-03-03 19:12:58 India Standard Time, Level=DEBUG, Pid=11120, Logger=splunklib.binding, File=binding.py, Line=72, Log message

@akaila-splunk
Used module-specific logger in splunklib code instead of root logger
00fadcb
@akaila-splunk
add method to set logging for splunklib directory
ec06849
@akaila-splunk
add formatter for logs and update README.md file
fbeff52 
- add default time and log formatter in setup_logging() method
- add details of setup_logging() method and logging.conf files in README.md file
fantavlik
fantavlik approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thanks for walking us through the design along the way on our weekly syncs

@akaila-splunk akaila-splunk merged commit f1db833 into develop Mar 4, 2022
@akaila-splunk akaila-splunk mentioned this pull request Mar 25, 2022
Merged
@majiang majiang mentioned this pull request Mar 30, 2022
Closed
@akaila-splunk akaila-splunk deleted the DVPL-10608 branch May 2, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantavlik fantavlik fantavlik approved these changes

@zenmoto zenmoto Awaiting requested review from zenmoto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akaila-splunk @fantavlik