S1481: Unused local variables should be removed #3654
Conversation
|
while unused, I think there was a debugging purpose to this but those authors are long gone I believe. Will leave to others to decide if to remove. I've seen these but left them since they are doing calculations and I could see during debug that might be useful. |
|
@JuditKnoll @gtoison Do either of you care to keep the calculations or ok with their removal? Will leave that up to you two to decide, maybe these just needed logging added so they actually do something ;) |
I'm ok with their removal. The code changes look okay to me (not even in commented out code are those fields referenced), the changelog entry could be improved (left a comment there). |
Make sure these boxes are checked before submitting your PR -- thank you!
Added an entry into
CHANGELOG.mdif you have changed SpotBugs codehttps://docs.openrewrite.org/recipes/staticanalysis/removeunusedlocalvariables
https://docs.pmd-code.org/latest/pmd_rules_java_bestpractices.html#unusedprivatefield
https://sonarsource.github.io/rspec/#/rspec/S1481