Fix scheduling tasks with many deps/params.#409
Conversation
Contributor
|
LGTM but it would be great if we can switch to POST instead! |
Contributor
Author
|
Yes, I was just a bit afraid to make a change that big. See #411, hopefully I didn't break anything. |
erikbern
pushed a commit
that referenced
this pull request
Aug 28, 2014
Fix scheduling tasks with many deps/params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tornado limits maximum size of HTTP request (without body) to 65536 bytes by default. If there is a task with many parameters and/or dependencies, it could fail to be scheduled. Luigi server just closes RPC connection, logging this:
This commit increases that limit to 2MB. "Two megabytes ought to be enough for anyone."