This repository was archived by the owner on May 14, 2025. It is now read-only.
Add random number to k8s task deployment id. #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid duplicate deployment id when multiple tasks launched simultaneously. Fixes spring-attic#399
corneil
reviewed
Sep 14, 2023
onobc
commented
Sep 14, 2023
.../src/main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesTaskLauncher.java
Outdated
Show resolved
Hide resolved
This reverts commit 68c0d2d.
Avoid duplicate deployment id when multiple tasks launched simultaneously. Fixes spring-attic#399
onobc
added a commit
to onobc/spring-cloud-deployer
that referenced
this pull request
Sep 14, 2023
* Add random number to k8s task deployment id. Avoid duplicate deployment id when multiple tasks launched simultaneously. Fixes spring-attic#399 Co-authored-by: Corneil du Plessis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid duplicate deployment id when multiple tasks launched simultaneously.
Fixes #399