Allow keys other than _id for primary key in MongoItemWriter #4812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving data between different data store types, such as between MongoDB and a SQL database, not all systems have a "_id" as their pimary key. Most often it has a different name or can be multiple keys/columns used as a composite key. This change allows the app to specify an alternate key or a set of keys which, together, can be used as the primary key for a MongoDB insert/update/upsert. Signed-off-by: blake_bauman <[email protected]>
|
@fmbenhassine Does this seem reasonable? |
|
Yes, and the change is backward compatible. Thank you for the PR! I will plan this for v6.0.0 / v5.2.3. |
|
Thanks for this! |
|
LGTM 👍 Rebased and merged as 08085d3 and will be included in the upcoming v5.2.3. Thank you for your contribution! |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving data between different data store types, such as between MongoDB and a SQL database, not all systems have a "_id" as their pimary key. Most often it has a different name or can be multiple keys/columns used as a composite key. This change allows the app to specify an alternate key or a set of keys which, together, can be used as the primary key for a MongoDB insert/update/upsert.