Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

hasnainjaved
Copy link
Contributor

I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

confirmation code is: 8662014070602225

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of the conditional, is there a reason not to just override it so the reader can be consistent with the other reader behaviors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Sorry I did not get you. Could you kindly elaborate a bit more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're checking to see if the Query has the limit set. Is there a reason why you wouldn't just always override the limit with what's configured in the reader (or at least giving the values in the reader precedence)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Apologies for the late reply. Changes have been made.

AbstractPaginatedDataItemReader will now be used to set the limit on the
data returned by the query. updated README file
@evanwan87
Copy link

evanwan87 commented Feb 9, 2017

it's helpful! i wonder when will release this version?

Copy link

@sharmilakale sharmilakale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this class CouchbaseItemReader used? I don't see any other information on google about this class other than this source code.

@fmbenhassine
Copy link
Contributor

@hasnainjaved As mentioned in #46 , we are planning to start releasing modules from this repository to Maven Central so that the community can benefit from them without having to build/host the artefacts.

As the author of this couchbase item reader/writer, would you be interested in taking the lead on this module? Looking forward to your feedback.

@deepmalasrivastav
Copy link

Is couchbase read/write suppoert in spring batch released? I have requirement of reading data from couchbase db in batches and send event to kafka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants