Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Provide extensions that remove the need for the log4j-spring-boot log4j2 module #32578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Provide extensions that remove the need for the log4j-spring-boot log4j2 module #32578

wants to merge 1 commit into from

Conversation

rgoers
Copy link
Contributor

@rgoers rgoers commented Oct 4, 2022 •
edited by philwebb
Loading

This change merges the contents of the log4j-spring-boot module into Spring Boot, effectively making Log4j 2 on par with Logback and eliminating the need for the log4j-spring-boot module.

I was able to verify this with a sample project I have.

(edit)

The following sub-tasks have been created based on this PR:

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 4, 2022
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 5, 2022
@philwebb philwebb self-assigned this Oct 5, 2022
@philwebb philwebb added this to the 3.0.x milestone Oct 5, 2022
@philwebb philwebb changed the title Integrate full Log4j2 support into Spring Boot Provide extensions that remove the need for the log4j-spring-boot log4j2 module Oct 14, 2022
@philwebb philwebb modified the milestones: 3.0.x, 3.0.0-RC1 Oct 14, 2022
philwebb added a commit that referenced this pull request Oct 14, 2022
@philwebb
Document Log4j2 extensions
029aab6 
See gh-32578
@philwebb philwebb closed this in b12fda2 Oct 14, 2022
@philwebb
Copy link
Member

Thanks very much @rgoers, and thanks for your patience whilst we go to this. I've split the PR into a number of distinct issues so that our automated changelog is correct.

I made a few amendments to some of the functionality, namely:

  • I removed the ability in StrLookup to resolve profiles.active and profiles.enabled. This simplifies quite a bit of code and I can't think of a good reason why users should need to resolve the profiles.
  • A few of the extensions now fail hard if the Environment isn't available when they're used
  • URL based lookups must resolve a config and if they don't the application will fail to start

I've also added a new section in the reference guide to explain the features.

Thanks again for the contribution and for all your hard work on Log4j2!

izeye added a commit to izeye/spring-boot that referenced this pull request Oct 15, 2022
@izeye
Polish Log4j2 changes
3040da8 
See spring-projectsgh-32578
@izeye izeye mentioned this pull request Oct 15, 2022
Closed
@ppkarwasz ppkarwasz mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.0-RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@rgoers @philwebb @spring-projects-issues