-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Merge pull request #1 #5976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Merge pull request #1 #5976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willseeyou
commented
May 16, 2016
- [] I have signed the CLA
Previously, a JVM that was forked by spring-boot:run could be orphaned when the parent process (the Maven build) was terminated in an IDE. Note that this doesn’t happen when spring-boot:run is invoked from a shell. This commits add a shutdown hook that registered when RunMojo forks the JVM. The shutdown hook attempts to kill the forked JVM’s RunProcess rather than relying on the death of the parent process being sufficient to also kill the child. Closes gh-5815
This commit streamlines the Integration Starter by removing the file http, ip, and stream modules as they are not always used by a majority of apps that use Spring Integration and can also pull in other, unwanted dependencies. Additionally, a dependency on spring-integration-java-dsl has been added. This makes it easy for users to configure Spring Integration using Java configuration (the recommended approach), rather than via XML. The Integration sample has been updated to use the DSL. Further improvements could be made once the sample is using Java 8. Closes gh-5528
* pr/5727: Replacing StringBuffer with lock-free StringBuilder
Closes gh-5731
* pr/5731: Remove duplicate words
…runs Previously, SpringBootContextLoader configured the environment with the test property sources using an ApplicationContextInitializer. This was because TestPropertySourceUtils did not provide a method to directly configure the environment using properties files, it had to be done via an application context. An unwanted side-effect of this was that the test property sources were not being configured before ConfigFileApplicationListener examined the environment to determine the name and locations of the files that it should be loading. This commit takes advantage of a new method that was added to TestPropertySourceUtils which allows properties files to be added directly to the environment without using an application context. This means that the use of the ApplicationContextInitializer can be removed and the test property sources can be applied to the environment before the application context is created. Closes gh-5728
Previously, the classpath would be logged in response to the ApplicationStartedEvent. At this point, logging could be disabled while the logging system is being initialized, or because the log levels configured in the environment have not yet been applied. This commit moves the logging to happen in response to an ApplicationEnvironmentPreparedEvent by which point the logging system has been initialized and its levels have been configured. Closes gh-5313
* pr/5720: Remove the second parameter of substring() if possible
Previously, the Gradle plugin would include all of the dependencies from both the compile and runtime configurations in the repackaged jar. In the unlikely event that the compile and runtime configurations contained different versions of the same dependency, this would lead to both versions of the dependency being packaged in the jar file. The runtime configuration extends the compile configuration so, in normal circumstances, it will contain a superset of the compile configuration's dependencies. In the situation described above where the two configurations contain different versions of the same dependency the runtime configuration will only contain whichever version of the two dependencies has "won". By default, this will be the dependency with the higher version. This commit updates the Gradle plugin to only include the runtime configuration's resolved dependencies during repackaging. As explained above, the runtime configuration extends the compile configuration so any compile dependencies will still be included, with the added benefit that duplicate versions of the same dependency will have been resolved to a single, preferred version. Closes gh-5749
Commit b7e7bcf made `spring.session.store-type` explicit which means that users of Spring Session in 1.3 have to set that property to restore the auto-configuration support in 1.4. This commit implicitly set the store type to redis if redis is present and log a warning inviting the user to actually specify that in configuration. The entry in the auto-configuration report also mentions that such arrangement is deprecated. Closes gh-5838
This commit validates that a `SessionRepository` has been configured if Spring Boot is meant to auto-configure one. Closes gh-5943
Closes gh-5940
Closes gh-5958
The `if` in registerSpies() is not required as it's covered by the Assert check. Closes gh-5889
Deprecate `PropertiesConfigurationFactory.setProperties()` since it was only being used in tests. Fixes gh-5930
Improve the message thrown when a @PropertyMapping is used in combination with a @component to include the actual annotations that are causing the problem. Fixes gh-5897
@willseeyou I'm blocking you from this repository due to the fact that you're continually posting empty pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.