Add HQL single-character member coverage.#4289
Closed
jewoodev wants to merge 1 commit into
Closed
Conversation
Verify that HQL accepts single-character string literals in collection membership predicates. Cover member-of, negated member-of, subquery, update, and delete surfaces. Signed-off-by: jewoodev <[email protected]>
mp911de
pushed a commit
that referenced
this pull request
Jul 2, 2026
Signed-off-by: jewoodev <[email protected]> See #4278 Original pull request: #4289
mp911de
pushed a commit
that referenced
this pull request
Jul 2, 2026
Signed-off-by: jewoodev <[email protected]> See #4278 Original pull request: #4289
mp911de
pushed a commit
that referenced
this pull request
Jul 2, 2026
Signed-off-by: jewoodev <[email protected]> See #4278 Original pull request: #4289
Member
|
Thank you for your contribution. That's merged and backported now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add focused HQL renderer coverage for single-character string literals used as the left operand of collection membership predicates.
As a follow-up to #4278, I also checked the JPQL/EQL grammar change for unintended widening. The only meaningful new parse surface is the intended collection membership predicate shape (
MEMBER OF/NOT MEMBER OF); common existing single-character literal positions such as comparisons,IN, constructors,LIKE,TRIM, functions,CASE, and update assignments continue to parse as before.HQL does not share the same root cause because quoted strings are handled as
STRING_LITERAL, without a separate single-character token. This PR leaves the HQL grammar unchanged and adds coverage formember of,not member of, subquery, update, and delete surfaces.Verified with the HQL query renderer test suite.
See #4278