Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add HQL single-character member coverage.#4289

Closed
jewoodev wants to merge 1 commit into
spring-projects:mainfrom
jewoodev:gh-4278-hql-member-literal-coverage
Closed

Add HQL single-character member coverage.#4289
jewoodev wants to merge 1 commit into
spring-projects:mainfrom
jewoodev:gh-4278-hql-member-literal-coverage

Conversation

@jewoodev

Copy link
Copy Markdown
Contributor

Add focused HQL renderer coverage for single-character string literals used as the left operand of collection membership predicates.

As a follow-up to #4278, I also checked the JPQL/EQL grammar change for unintended widening. The only meaningful new parse surface is the intended collection membership predicate shape (MEMBER OF/NOT MEMBER OF); common existing single-character literal positions such as comparisons, IN, constructors, LIKE, TRIM, functions, CASE, and update assignments continue to parse as before.

HQL does not share the same root cause because quoted strings are handled as STRING_LITERAL, without a separate single-character token. This PR leaves the HQL grammar unchanged and adds coverage for member of, not member of, subquery, update, and delete surfaces.

Verified with the HQL query renderer test suite.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

See #4278

Verify that HQL accepts single-character string literals in collection
membership predicates.

Cover member-of, negated member-of, subquery, update, and delete
surfaces.

Signed-off-by: jewoodev <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 23, 2026
@mp911de mp911de self-assigned this Jun 29, 2026
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 29, 2026
mp911de pushed a commit that referenced this pull request Jul 2, 2026
Signed-off-by: jewoodev <[email protected]>

See #4278
Original pull request: #4289
mp911de pushed a commit that referenced this pull request Jul 2, 2026
Signed-off-by: jewoodev <[email protected]>

See #4278
Original pull request: #4289
mp911de pushed a commit that referenced this pull request Jul 2, 2026
Signed-off-by: jewoodev <[email protected]>

See #4278
Original pull request: #4289
@mp911de mp911de added this to the 4.0.7 (2025.1.7) milestone Jul 2, 2026
@mp911de

mp911de commented Jul 2, 2026

Copy link
Copy Markdown
Member

Thank you for your contribution. That's merged and backported now.

@mp911de mp911de closed this Jul 2, 2026
@jewoodev jewoodev deleted the gh-4278-hql-member-literal-coverage branch July 2, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants