Thanks to visit codestin.com
Credit goes to github.com

Skip to content

#34788 - HierarchicalUriComponents can handle repeated params in a query #35658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

#34788 - HierarchicalUriComponents can handle repeated params in a query #35658

wants to merge 4 commits into from
+144 −88

Conversation

@FBibonne
Copy link
Contributor

@FBibonne FBibonne commented Oct 17, 2025 •
edited
Loading

Use List instead of MultiValueMap in HierarchicalUriComponents to record query params

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 17, 2025
@FBibonne
feat (Uri components builder expanded) query params key can be duplic…
742fedd 
…ated spring-projects#34788

- Use List<QueryParam> instead of MultiValueMap in  HierarchicalUriComponents to record query params

Signed-off-by: Fabrice Bibonne <[email protected]>
@FBibonne FBibonne force-pushed the gh-34788-uriComponentWithDulpicatedKeys branch from 9c5a475 to 742fedd Compare October 17, 2025 14:43
@FBibonne
Copy link
Contributor Author

FBibonne commented Oct 17, 2025

Solves #34788

@FBibonne FBibonne marked this pull request as draft October 17, 2025 14:44
@FBibonne FBibonne changed the title feat (Uri components builder expanded) query params key can be duplicated #34788 - Use List<QueryParam> instead of MultiValueMap in HierarchicalUriComponents to record query params #34788 - HierarchicalUriComponents can handle repeated params in a query Oct 17, 2025
@FBibonne
fix (URI components) style check errors
42e5f3a 
Signed-off-by: Fabrice Bibonne <[email protected]>
@FBibonne
fix (URI components) test
8a1a56a 
- fix MockHttpServletRequestBuilderTests#queryParameterWithoutValues

Signed-off-by: Fabrice Bibonne <[email protected]>
@FBibonne
test (URI components) correct tests impacted by feature
6d75001 
- order of params change in result expressions in a few tests : expected results have to be changed

Signed-off-by: Fabrice Bibonne <[email protected]>
@FBibonne FBibonne marked this pull request as ready for review October 18, 2025 04:55
@FBibonne
Copy link
Contributor Author

FBibonne commented Oct 18, 2025

While working on the PR I had to fix some tests, not directly related to URI compononents, like RequestLoggingFilterTests::queryStringIncluded
So the changes in URI components, as they modify the order of query params, can fail tests which assert an URI : it is true inside the spring framework tests but this can also be true outside : this may be a breaking change.

@rstoyanchev rstoyanchev added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) status: waiting-for-triage An issue we've not yet triaged or decided on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FBibonne @rstoyanchev @spring-projects-issues