Fix inverted logic for boolean last flag in JettyWebSocketSession when sending binary message#36650
Closed
mguiking wants to merge 2 commits into
Closed
Fix inverted logic for boolean last flag in JettyWebSocketSession when sending binary message#36650mguiking wants to merge 2 commits into
mguiking wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Hi, nice catch on the inverted logic here - by changing it to !iteratior.hasNext() flips the logic so the final buffer signals the end of the message (FIN = 1). Without this the last buffer was signalling more data was to come. Maybe adding a test case can help prove the fix works.
Contributor
|
I noticed there isn't a dedicated unit test for this webflux module yet maybe adding it to the existing WebSocketIntegrationTests.java or creating a new JettyWebSocketSessionTests in the adapter folder? |
DhruvTheDev1
approved these changes
Apr 21, 2026
DhruvTheDev1
left a comment
Contributor
There was a problem hiding this comment.
Hi, the tests look solid - checking for the false, false, true sequence proves the logic flip is correct for the fragmented messages. Looks good to me!
Signed-off-by: Max Guiking <[email protected]> Signed-off-by: Max Guiking <[email protected]>
… handling Signed-off-by: Max Guiking <[email protected]>
pull Bot
pushed a commit
to Clarence404/spring-framework
that referenced
this pull request
May 27, 2026
See spring-projectsgh-36650 Signed-off-by: Max Guiking <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendPartialBinary'slastparameter controls the WebSocket FIN bit — true means "this is the final fragment." Spring sets it toiterator.hasNext()which is inverted: for a single-buffer binary message, last becomes false, so Jetty leaves the connection in a fragmented state (FIN=0). The next send (e.g. a text message) then fails.