Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix missing nullability in JdbcTemplate.batchUpdate#37012

Closed
alshain wants to merge 2 commits into
spring-projects:mainfrom
alshain:patch-1
Closed

Fix missing nullability in JdbcTemplate.batchUpdate#37012
alshain wants to merge 2 commits into
spring-projects:mainfrom
alshain:patch-1

Conversation

@alshain

@alshain alshain commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Updated batchUpdate method signatures to allow nullable Object arrays.

Fixes #37011

Updated batchUpdate method signatures to allow nullable Object arrays.

Fixes spring-projects#37011 37011

Signed-off-by: Chris <[email protected]>
@sdeleuze sdeleuze self-assigned this Jul 7, 2026
@sdeleuze sdeleuze added this to the 7.0.9 milestone Jul 7, 2026
@sdeleuze sdeleuze added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement labels Jul 7, 2026
@sdeleuze

sdeleuze commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@alshain The build seems to be broken by this change, could you please double check locally?

@alshain

alshain commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the near instant reply @sdeleuze . Unfortuntely, our corporate proxy setup would have me chnage everything to our Nexus, that seems infeasible.

I've taken a guess at the needed local nullability annotations. Could you trigger the build again?

@sdeleuze

sdeleuze commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

I am running another build on the CI to check.

All commits must include a Signed-off-by trailer at the end of each commit message, see https://github.com/spring-projects/spring-framework/blob/main/CONTRIBUTING.md#submit-a-pull-request for more details. Maybe squash the 2 commits to a single one with the required trailer and force-push?

@sdeleuze

sdeleuze commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Still broken, I think you should find a way to run the test locally.

@alshain

alshain commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@sdeleuze I'll try to do it at home, there it should be no problem.

@sdeleuze

sdeleuze commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

I am currently merging various PRs, so don't bother, I will take it from there and refine.

@sdeleuze

sdeleuze commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Also note that I will modify your contribution to use List<? extends @Nullable Object[]> in order to allow both nullable and non-nullable elements in the generic type. I think this is the first time we have a use case for a list of array, but I think that applies there. I will add a Kotlin test case to double check it works as expected.

@sdeleuze sdeleuze closed this in 16e82cd Jul 8, 2026
pull Bot pushed a commit to 86dh/spring-framework that referenced this pull request Jul 8, 2026
Updated batchUpdate method signatures to allow nullable Object arrays.

See spring-projectsgh-37012

Signed-off-by: Chris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Nullability annotation on JdbcTemplate.batchUpdate

2 participants