Introduce Parameter-based factory methods in TypeDescriptor#37015
Open
sunnyboy33 wants to merge 2 commits into
Open
Introduce Parameter-based factory methods in TypeDescriptor#37015sunnyboy33 wants to merge 2 commits into
sunnyboy33 wants to merge 2 commits into
Conversation
Signed-off-by: sunnyboy33 <[email protected]>
Signed-off-by: sunnyboy33 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Similar to the recent enhancement in
ResolvableType(gh-36545) which introducedResolvableType.forParameter(Parameter parameter)as a convenience factory method, this PR introduces equivalent parameter-based convenience static factory methods inTypeDescriptor.Previously, to obtain a
TypeDescriptorfrom ajava.lang.reflect.Parameter, developers had to go throughMethodParameter.forParameter(parameter)explicitly, which is verbose.This PR introduces:
TypeDescriptor.forParameter(Parameter parameter)TypeDescriptor.nested(Parameter parameter, int nestingLevel)Usage Examples (Before vs. After)
Before:
After (New API):
Description of Changes
TypeDescriptor: Added imports forjava.lang.reflect.Parameterand implemented the new static factory methodsforParameter(Parameter)andnested(Parameter, int).TypeDescriptorTests: Added corresponding unit tests:forParameter(): Verifies creation ofTypeDescriptorfrom a validParameter.forParameterMustNotBeNull(): Ensuresnullinput triggers anIllegalArgumentExceptionwith the correct assertion message.nestedParameter(): Verifies nested type traversal from aParametersource.nestedParameterMustNotBeNull(): Ensuresnullinput to the nested factory triggersIllegalArgumentException.Verification Run
All unit tests in the
spring-coremodule have been executed and pass successfully:./gradlew :spring-core:test --tests "org.springframework.core.convert.TypeDescriptorTests"