Support ethers v6#147
Merged
Merged
Conversation
w4ll3
reviewed
Apr 4, 2023
w4ll3
left a comment
Member
There was a problem hiding this comment.
Hi again, can you please rebase with latest merged changes?
* loosen peerDependencies on siwe * set up ethers5 and ethers6 devDependencies to enable testing with both versions * allow test runner to select ethers 5 or 6 * create a compatibility layer that exports the right functions based on whether we are using ethers v5 or v6
1aef29c to
75b7f2e
Compare
Contributor
Author
|
@w4ll3 updated! |
This was referenced Apr 5, 2023
Closed
w4ll3
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces compatibility with ethers v6. It's a bit hacky, but it works.