Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PR: Add initial Methods, helpers and QtPy namespace specifics section to the README #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2022
Merged

PR: Add initial Methods, helpers and QtPy namespace specifics section to the README #357

merged 3 commits into from
Jul 25, 2022

Conversation

dalthviz
Copy link
Member

Fixes #61

@dalthviz dalthviz requested a review from CAM-Gerlach July 21, 2022 19:29
@dalthviz dalthviz self-assigned this Jul 21, 2022
@dalthviz dalthviz added this to the v2.2.0 milestone Jul 21, 2022
@dalthviz dalthviz changed the title PR: Add initial 'Methods, helpers and QtPy namespace specifics' section to the README PR: Add initial Methods, helpers and QtPy namespace specifics section to the README Jul 21, 2022
@dalthviz dalthviz requested a review from ccordoba12 July 21, 2022 19:33
CAM-Gerlach
CAM-Gerlach reviewed Jul 22, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dalthviz , this is a big improvement. Some textual fixes and improvements:

dalthviz and others added 2 commits July 22, 2022 11:28
CAM-Gerlach
CAM-Gerlach reviewed Jul 22, 2022
View reviewed changes
CAM-Gerlach
CAM-Gerlach approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM thanks 👍

ccordoba12
ccordoba12 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@dalthviz
Copy link
Member Author

dalthviz commented Jul 25, 2022 •
edited
Loading

Who wants to merge this @CAM-Gerlach @ccordoba12 ?

@ccordoba12 ccordoba12 merged commit 78ee3de into spyder-ide:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Assignees

@dalthviz dalthviz

Labels
type:Task
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

Add documentation for methods or helpers that are specific to qtpy
3 participants
@dalthviz @ccordoba12 @CAM-Gerlach