CI: Ensure conda-forge channel usage when testing with conda #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
requested changes
Aug 11, 2022
There was a problem hiding this comment.
channels: conda-forge is already set in the setup-miniconda step in the workflow, so the -c conda-forge are redundant here and have no additional effect (thus the test still fails).
Instead, if you drop this commit and just add channel-priority: strict to the aforementioned step in the ci.yaml workflow, everything should work as expected.
3f3c904 to
8d08245
Compare
CAM-Gerlach
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
LGTM, thanks @dalthviz !
Since this is a small change and fixes the CIs, I'll go ahead and merge right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the env for Windows with Python 3.7 and PyQt 5.9 on the CI is not working