PR: Enable more tests on CI #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have hope that I found all test to uncomment. |
dalthviz
reviewed
Jun 5, 2023
There was a problem hiding this comment.
Thanks @Czaki for working on this! Checking seems like maybe there is just one more test which skip on linux could be removed:
qtpy/qtpy/tests/test_compat.py
Line 12 in 1874fba
Other than that this LGTM 👍
However, just in case, what do you think @CAM-Gerlach and @ccordoba12 ?
|
I have removed it and all Linux test pass :) |
ccordoba12
reviewed
Jun 5, 2023
ccordoba12
approved these changes
Jun 5, 2023
|
Merge (to unblock the second PR)? |
|
Sure, let's do it! I was waiting for @dalthviz, but since he's not available this week and this doesn't affect the library itself, I think it's fine to proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have added installation of libs required by qt to setup
QApplication. For this, I have usedtlambert03/setup-qt-libs@v1. This action is used in few projects testing Qt (like napari) so if new Qt version requires some additional library it will be added without the need to make such a patch in all projects.