Add support for es module and browser-only environment #539

stephen · 2023-01-02T14:03:41Z

This PR addresses #284.

I've tested this change using the current create-react-app along with this webpack config:

configure: (webpackConfig) => {
  webpackConfig.resolve.extensions.push(".wasm");
  webpackConfig.experiments = {
    asyncWebAssembly: true,
    topLevelAwait: true,
  };
  webpackConfig.module.rules.forEach((rule) => {
    (rule.oneOf || []).forEach((oneOf) => {
      if (oneOf.type === "asset/resource") {
        oneOf.exclude.push(/\.wasm$/);
      }
    });
  });
  return webpackConfig;
},

This change prevents webpack and other junk from doing errors like: https://stackoverflow.com/questions/59487224/webpack-throws-error-with-emscripten-cant-resolve-fs Other notes: https://esbuild.github.io/api/#main-fields-for-package-authors

This was tricky to figure out. Using the ENVIRONMENT=web flag for the browser build started causing prepared statements to fail - it would behave as if no params were passed to db.exec("...", []) as the second arg. It turns out that the closure compiler was removing the bind() call.. It's not clear to me why, but adding externs that map out the exported structure fixes the issue. Some other notes: - emscripten runs with ADVANCED mode for closure compiler - closure compiler reuses variables... - use --closure-args=--debug and --closure-args=--pretty-print for clues

stephen added 3 commits January 3, 2023 00:55

makefile: add esmodule target

e9bcc46

*: add browser only build

5772548

This change prevents webpack and other junk from doing errors like: https://stackoverflow.com/questions/59487224/webpack-throws-error-with-emscripten-cant-resolve-fs Other notes: https://esbuild.github.io/api/#main-fields-for-package-authors

readme: document es module usage

5aad0da

stephen mentioned this pull request Jan 2, 2023

Feature request: Support ES module #284

Open

oleghein mentioned this pull request Jun 27, 2023

Can't resolve 'fs' #544

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for es module and browser-only environment #539

Add support for es module and browser-only environment #539

Uh oh!

stephen commented Jan 2, 2023

Uh oh!

Uh oh!

Add support for es module and browser-only environment #539

Are you sure you want to change the base?

Add support for es module and browser-only environment #539

Uh oh!

Conversation

stephen commented Jan 2, 2023

Uh oh!

Uh oh!