Type array_agg() #12461
Closed
Type array_agg() #12461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return type of array_agg() is declared as a `Sequence[T]` where `T` is bound to the type of input argument. This is implemented by making array_agg() inheriting from ReturnTypeFromArgs which provides appropriate overloads of `__init__()` to support this. This usage of ReturnTypeFromArgs is a bit different from previous ones as the return type of the function is not exactly the same as that of its arguments, but a "collection" (a generic, namely a Sequence here) of the argument types. Accordingly, we adjust the code of tools/generate_sql_functions.py to retrieve the "collection" type from 'fn_class' annotation and generate expected return type accordingly. Also add a couple of hand-written typing tests for PostgreSQL.
CaselIT
reviewed
Mar 24, 2025
CaselIT
reviewed
Mar 24, 2025
sqla-tester
reviewed
Mar 24, 2025
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision ba27cbb of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change ba27cbb: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5797 |
|
thanks! |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5797 has been merged. Congratulations! :) |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5798 has been merged. Congratulations! :) |
sqlalchemy-bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
The return type of `array_agg()` is declared as a `Sequence[T]` where `T` is bound to the type of input argument. This is implemented by making `array_agg()` inheriting from `ReturnTypeFromArgs` which provides appropriate overloads of `__init__()` to support this. This usage of ReturnTypeFromArgs is a bit different from previous ones as the return type of the function is not exactly the same as that of its arguments, but a "collection" (a generic, namely a Sequence here) of the argument types. Accordingly, we adjust the code of `tools/generate_sql_functions.py` to retrieve the "collection" type from 'fn_class' annotation and generate expected return type. Also add a couple of hand-written typing tests for PostgreSQL. Related to #6810 Closes: #12461 Pull-request: #12461 Pull-request-sha: ba27cbb Change-Id: I3fd538cc7092a0492c26970f0b825bf70ddb66cd (cherry picked from commit 543acbd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type of
array_agg()is declared as aSequence[T]whereTis bound to the type of input argument.This is implemented by making
array_agg()inheriting fromReturnTypeFromArgswhich provides appropriate overloads of__init__()to support this.This usage of ReturnTypeFromArgs is a bit different from previous ones as the return type of the function is not exactly the same as that of its arguments, but a "collection" (a generic, namely a Sequence here) of the argument types. Accordingly, we adjust the code of
tools/generate_sql_functions.pyto retrieve the "collection" type from 'fn_class' annotation and generate expected return type.Also add a couple of hand-written typing tests for PostgreSQL.
Related to #6810