-
Notifications
You must be signed in to change notification settings - Fork 366
Update: Add Support for PostgreSQL v13 #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codebreaker32
wants to merge
19
commits into
sqlancer:main
Choose a base branch
from
codebreaker32:update/postgres_v13
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified "SIMILAR TO .... ESCAPE NULL" to avoid explicit NULL returns in PostgreSQL v13 - Fixed usage of `SIMILAR TO` in the codebase
e1ffe83
to
e40fedd
Compare
Hey @mrigger |
b53fa29
to
83c0c88
Compare
83c0c88
to
db8d8f5
Compare
mrigger
reviewed
Mar 23, 2025
mrigger
reviewed
Mar 23, 2025
mrigger
reviewed
Mar 23, 2025
mrigger
reviewed
Mar 23, 2025
Hi @mrigger I have made following changes:-
|
Hi @mrigger please review! |
mrigger
reviewed
Mar 29, 2025
mrigger
reviewed
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
SIMILAR TO .. ESCAPE NULL
explicitly returnsnull
ESCAPE
in PostgresToStringVisitor.javaImplementation
SIMILAR TO ... ESCAPE NULL
to avoid explicit NULL returns in PostgreSQL v13-- In postgres v12
ESCAPE NULL
SIMILAR TO
in the codebase-- In previous version,
visit
function didn't append "ESCAPE" to the query.public void visit(PostgresSimilarTo op) {
sb.append("(");
visit(op.getString());
sb.append(" SIMILAR TO ");
visit(op.getSimilarTo());
if (op.getEscapeCharacter() != null) {
visit(op.getEscapeCharacter());
}
sb.append(")");
}
RESET
(TODO task)Partially resolves #912
Reference : Postgres Release Notes v13