Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for Explain Analyze for Postgres v13 #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for Explain Analyze for Postgres v13 #1230

wants to merge 1 commit into from

Conversation

yaojiejia
Copy link
Contributor

Closes 12. EXPLAIN ANALYSE from #912

mrigger
mrigger reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@mrigger mrigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code is currently used only by the Query Plan Guidance (QPG) component. If we execute ANALYZE for it, performance would drop. I guess we could have separate public methods, one for QPG and one that we use in the provider class.

@yaojiejia
Copy link
Contributor Author

I think the code is currently used only by the Query Plan Guidance (QPG) component. If we execute ANALYZE for it, performance would drop. I guess we could have separate public methods, one for QPG and one that we use in the provider class.

I see, looking over the PostgresProvider class, I can only see that the PostgresExplainGenerator is being used in getQueryPlan method which it will definitely drop the performance by adding the analyze part, but you also mentioned I should create another method for the provider class, could you maybe elaborate on that part?

@mrigger
Copy link
Contributor

mrigger commented Jun 9, 2025

We could add an enum (see

sqlancer/src/sqlancer/postgres/PostgresProvider.java

Line 129 in 49c7358

CREATE_VIEW(PostgresViewGenerator::create);
). In this enum, we can specify a newly-created method in the explain generator that can generate the full range of EXPLAIN, while we can keep using the restricted method for QPG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrigger mrigger mrigger left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaojiejia @mrigger