refactor(codegen): Removed deprecated code and improved speed #2899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. The test failures are expected. We are using an authenticated feature of sqlc cloud in our CI pipeline for some tests, and CI runs based on pull requests from outside contributors don't get access to secrets, so authentication fails. I'll wait for @kyleconroy to give final sign-off though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just tiny change for single file:
strings.Titlecause this function is deprecatedstrings.Mapstrings.Replaceto simple, fast and single line solutionWhy this pr? I just probing how good contribution pipeline is for this repo, wanna make a lot of good improvements 😊