Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use MySQL 9 in docker-compose.yml #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Use MySQL 9 in docker-compose.yml #3944

merged 1 commit into from
May 22, 2025

Conversation

vvakame
Copy link
Contributor

@vvakame vvakame commented Apr 28, 2025

I got an error when execute make test in my local env with make start.

--- FAIL: TestValidSchema (0.19s)
    --- FAIL: TestValidSchema/endtoend-testdata/mysql_vector/mysql/sqlc.json-0 (0.02s)
        ddl_test.go:56: CREATE TABLE foo(
                id INT PRIMARY KEY auto_increment,
                embedding VECTOR(4)
            );: Error 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'VECTOR(4)
            )' at line 3

I am not familiar with MySQL, but from what I've researched, VECTOR data type appears to be supported from version 9 1.
sqlc's CI workflow uses version 9 too 2.

Footnotes

  1. https://dev.mysql.com/doc/relnotes/mysql/9.0/en/news-9-0-0.html#mysqld-9-0-0-vectors ↩

  2. https://github.com/sqlc-dev/sqlc/blob/v1.29.0/.github/workflows/ci.yml#L64 ↩

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 28, 2025
@vvakame vvakame mentioned this pull request Apr 28, 2025
Open
@kyleconroy kyleconroy merged commit a60f370 into sqlc-dev:main May 22, 2025
8 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvakame @kyleconroy