Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove duplication of the raw textual representation of all SQLite data types #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2020
Merged

Remove duplication of the raw textual representation of all SQLite data types #1988

merged 2 commits into from
Sep 27, 2020

Conversation

@veyndan
Copy link
Collaborator

@veyndan veyndan commented Sep 27, 2020

Counterpart to sqldelight/sql-psi#190.

@veyndan
Copy link
Collaborator Author

veyndan commented Sep 27, 2020

Not too sure why I'm getting this error:

> Task :compileKotlinJs FAILED
    e: /home/runner/work/sqldelight/sqldelight/sqldelight-gradle-plugin/src/test/kotlin-mpp/build/generated/sqldelight/code/Database/com/sample/TestQueries.kt: (11, 23): Unresolved reference: TestView
    e: /home/runner/work/sqldelight/sqldelight/sqldelight-gradle-plugin/src/test/kotlin-mpp/build/generated/sqldelight/code/Database/com/sample/kotlinmpp/DatabaseImpl.kt: (5, 19): Unresolved reference: TestView
    e: /home/runner/work/sqldelight/sqldelight/sqldelight-gradle-plugin/src/test/kotlin-mpp/build/generated/sqldelight/code/Database/com/sample/kotlinmpp/DatabaseImpl.kt: (78, 32): Unresolved reference: TestView
    e: /home/runner/work/sqldelight/sqldelight/sqldelight-gradle-plugin/src/test/kotlin-mpp/build/generated/sqldelight/code/Database/com/sample/kotlinmpp/DatabaseImpl.kt: (79, 5): Unresolved reference: TestView

I assumed it was a flaky build, but after rerunning the checks, they failed with the same error message. I also ran gradle compileKotlinJs locally and it runs without any errors 🤔

Idk if anyone's seen this error before, but if not, I can have a better look later

@AlecKazakova
Copy link
Collaborator

AlecKazakova commented Sep 27, 2020

i think i've seen that one before, its something non-deterministic where the view in kotlin-mpp test module returns the same projection as the table, so it will sometimes use the view class instead of the table class incorrectly (#1874)

i think you can fix by changing the view's projection to be unique: https://github.com/cashapp/sqldelight/blob/master/sqldelight-gradle-plugin/src/test/kotlin-mpp/src/commonMain/sqldelight/com/sample/Test.sq#L15

@AlecKazakova
Copy link
Collaborator

AlecKazakova commented Sep 27, 2020

i say non-determinstic but it happens reproducible depending on weird situations. anyways thats the fix and the bug to track the issue

@AlecKazakova AlecKazakova merged commit b466eb0 into sqldelight:sql-psi-dev Sep 27, 2020
@veyndan
Copy link
Collaborator Author

veyndan commented Sep 27, 2020 •
edited
Loading

Thanks @AlecStrong for the help! 🙏

@veyndan veyndan deleted the sqlite/data-types-separation branch September 27, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlecKazakova AlecKazakova AlecKazakova approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@veyndan @AlecKazakova