Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Paging 3 #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 28, 2022
Merged

Fix Paging 3 #3396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7299b74
Copy-paste Room LimitOffsetPagingSource.kt and associated files
veyndan Jul 19, 2022
89e18bd
Don't limit to library scope
veyndan Jul 25, 2022
6c9b913
Remove unnecessary constructor
veyndan Jul 25, 2022
4efa346
Remove unused argument
veyndan Jul 25, 2022
31b3f73
Remove usages of getQueryDispatcher
veyndan Jul 25, 2022
49eda6b
Remove usages of androidx.room.withTransaction
veyndan Jul 25, 2022
e1d997f
Remove usage of app.cash.sqldelight.paging3.util.queryItemCount
veyndan Jul 25, 2022
28ca396
Rename Value to RowType to align with SQLDelight
veyndan Jul 25, 2022
4ea18c0
Pass in a QueryProvider and then remove all fluff
veyndan Jul 25, 2022
5bf920c
Put queryDatabase within LimitOffsetPagingSource
veyndan Jul 25, 2022
c9e4b24
Use QueryPagingSource as the invalidater
veyndan Jul 25, 2022
ac9219a
Simplify
veyndan Jul 25, 2022
f24f92b
Copy-paste tests from AndroidX
veyndan Jul 25, 2022
562c092
Fix test compilation
veyndan Jul 28, 2022
2683237
Spotless
veyndan Jul 28, 2022
9bc2b43
Update extensions/android-paging3/src/test/java/app/cash/sqldelight/p…
veyndan Jul 28, 2022
03744d0
Update extensions/android-paging3/src/test/java/app/cash/sqldelight/p…
veyndan Jul 28, 2022
f3ce22b
Apply suggestions from code review
veyndan Jul 28, 2022
71501d2
Make the artifact a JVM one again
veyndan Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions extensions/android-paging3/android-test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
plugins {
alias(deps.plugins.android.library)
alias(deps.plugins.kotlin.android)
}

android {
namespace 'app.cash.sqldelight.paging3'
compileSdk deps.versions.compileSdk.get() as int
}

dependencies {
testImplementation project(':drivers:sqlite-driver')
testImplementation project(':extensions:android-paging3')
testImplementation deps.androidx.paging3.runtime
testImplementation deps.androidx.recyclerView
testImplementation deps.truth
testImplementation deps.kotlin.test.junit
testImplementation deps.kotlin.coroutines.test
}

// workaround for https://youtrack.jetbrains.com/issue/KT-27059
configurations.all {
resolutionStrategy.dependencySubstitution {
substitute module("${project.property("GROUP")}:runtime-jvm:${project.property("VERSION_NAME")}") with project(':runtime')
}
}
Loading