Enforce that synchronous drivers require a synchronous schema initializer #4013
Conversation
There was a problem hiding this comment.
This may be out of scope for this PR, but what do we actually gain from using the built in creation/migration APIs from Android (and the native driver)? Especially if we're going to be shipping an implementation of a SQLite-compatible auto upgrade function (#3737), I feel like it would be easier to create an async-compatible version of that function that could be used across all of our SQLite-based drivers rather than adding this quirky API.
I'm not very familiar with the native driver, or the inner workings of Android's SQLite support though so I'm likely missing some context.
drivers/android-driver/src/main/java/app/cash/sqldelight/driver/android/AndroidSqliteDriver.kt
Outdated
Show resolved
Hide resolved
drivers/android-driver/src/main/java/app/cash/sqldelight/driver/android/AndroidSqliteDriver.kt
Outdated
Show resolved
Hide resolved
...s/native-driver/src/nativeMain/kotlin/app/cash/sqldelight/driver/native/NativeSqlDatabase.kt
Outdated
Show resolved
Hide resolved
|
For Android our hand is kind of forced, there's a lot of complex connection management that eventually invokes those schema methods to deal with concurrent requests to get the database before its been initialized. It feels probably like the wrong thing to do to try and reinvent that, with pretty low upside. The Native driver is modeled after the support android stuff so I would expect it to be similar. TBH this is a big reason why I don't really want the JDBC creation helpers either. I don't like the idea of communicating to consumers that we have a mechanism for managing your db version, because thats kind of out of scope for sqldelight right now |
|
I feel like there is probably a better typesafe way of expressing that the generated code is asyncronous and that a driver is syncronous and failing at compile time. Like a sealed type for the schema, and drivers either accept an asynchronous, synchronous, or both schema. 🤔 |
|
Oh using a generic there is clever. I had to think for a moment if there would be any compatibility issues with drivers that can support both, but I guess that would be done by just passing
|
…izer - And provide an extension method for interoping in a multiplatform environment that requires both asynchronous and synchronous schemas.
…r/android/AndroidSqliteDriver.kt Co-authored-by: Derek Ellis <[email protected]>
…t/driver/native/NativeSqlDatabase.kt Co-authored-by: Derek Ellis <[email protected]>
55faa69 to
2a3afa8
Compare
2a3afa8 to
737a57f
Compare
Closes #3964
open to feedback on this idea as a way to solve it. Don't love the duplicated code in the android/native drivers but I think I prefer that over creating some new shared module for drivers