Reuse ConnectionManager in migration tasks #4019
Conversation
| import java.sql.* | ||
|
|
||
| class FooDialect : SqlDelightDialect by SqliteDialect() { | ||
| override val connectionManager: ConnectionManager = object: ConnectionManager by SqliteConnectionManager() { |
There was a problem hiding this comment.
You would only need these 10 lines, the existing lines from FooDialect are unrelated to your use-case.
AlecKazakova
left a comment
There was a problem hiding this comment.
I don't think this is right, the connection manager a dialect provides is essentially only to support all the IDE functionality that would use an active db connection. The connection used to verify migrations is only ever useful for SQLite since thats the only place where it even makes sense to have separate fresh/migration schemas that have to be compared.
|
or to put another way, the connection used to run queries from the IDE is never going to be the same as the one used to verify migrations, so I don't think theres any value in trying to share that connection |
|
Okay, was just an idea to reduce the api. |
Another PR regarding the VerifyMigrationTask and its classpath... this time reusing the ConnectionManager and its existing dialect api.