Add support for IntelliJ 2023.1 #4037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this locally against |
|
You would also need to include the new version there |
thanks, good hint! There are a bunch of compatibility errors as well, I'll take a look whether there are more things I missed. |
AlecKazakova
approved these changes
Apr 5, 2023
hfhbd
added a commit
that referenced
this pull request
Apr 7, 2023
* Update testcontainers-java monorepo to v1.18.0 (#4035) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Use runTest from kotlinx.coroutines (#3674) * Add buildscans to the sample (#4036) * Add support for IntelliJ 2023.1 (#4037) * Fix accessing KotlinFindUsagesHandlerFactory on newer IDEA * Fix mutating plugin classloader on newer IDEA * Remove debug log line * Fix spotless violations * Add IDEA 2023.1 to runPluginVerifier task * Fix compatibility issues as reported by plugin verifier * Fix spotless violations * Enable local build cache (#4038) * Update kotlin monorepo to v1.8.20 * Update plugin ksp to v1.8.20-1.0.10 (#4034) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update yarn lock file * Fix the sample tests * Fix sample js tests * Fix spotless --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Veyndan Stuart <[email protected]> Co-authored-by: Philip Wedemann <[email protected]> Co-authored-by: Madis Pink <[email protected]> Co-authored-by: hfhbd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4025
Two incompatibilities:
pluginClassLoaderreflection hack didn't work any more -filesfield had been removed and it looks like the functionality now depends on the internalClassPathfield. The method is quite naughty indeed :pKotlinFindUsagesHandlerFactorychanged it's package. I added a layer of indirection and some reflection on the newer versions, but there could be better strategies here.Feedback welcome as both of these are quite ugly hacks!