Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add join clause completion #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

Add join clause completion #4086

merged 1 commit into from
Apr 24, 2023

Conversation

aperfilyev
Copy link
Collaborator

Screen.Recording.2023-04-23.at.21.31.52.mov

@aperfilyev aperfilyev force-pushed the aperfilyev/join-completion branch from ef6ba90 to 326fc92 Compare April 23, 2023 18:46
@aperfilyev aperfilyev force-pushed the aperfilyev/join-completion branch from 326fc92 to afe9d44 Compare April 23, 2023 18:49
hfhbd
hfhbd approved these changes Apr 23, 2023
View reviewed changes
Copy link
Collaborator

@hfhbd hfhbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AlecKazakova
Copy link
Collaborator

very cool

@AlecKazakova AlecKazakova merged commit 7e9128a into sqldelight:master Apr 24, 2023
@aperfilyev aperfilyev deleted the aperfilyev/join-completion branch April 24, 2023 17:51
@vanniktech
Copy link
Contributor

This is really cool!

Would it also be possible to give suggestions for joining on the same table using the primary key?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfhbd hfhbd hfhbd approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aperfilyev @AlecKazakova @vanniktech @hfhbd