MySQL: support mysql types for binary expr and sum #4254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellderp
commented
Jun 9, 2023
| @@ -136,3 +175,7 @@ class MySqlTypeResolver( | |||
| ) | |||
| } | |||
| } | |||
|
|
|||
| private fun PsiElement.childOfType(types: TokenSet): PsiElement? { | |||
There was a problem hiding this comment.
This is copied from :sqldelight-compiler. I could add a dep instead but I'm not sure thats desirable.
There was a problem hiding this comment.
Another option: Move it from compiler into dialect. But I am fine with this copy here.
hfhbd
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple binary expressions like
bigint*bigintdid not work.sum(bigint)previously returned REAL, while in reality it returns INTEGER except when REAL is passed inAdded tests for min/max while I was here