-
Notifications
You must be signed in to change notification settings - Fork 540
Use Long as migration version #4297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Won't this require a (breaking) runtime change too? |
This isn’t part of the runtime, but part of the compiler which isn’t stable. |
Right, but |
Ah, you mean behavior, I thought about api only. |
generated code breakages are okay, since you cant have a published library that depends on that API |
Will rebase once a new sql-psi release is out. |
6a388de
to
d0bd7c1
Compare
Should we also change it upstream in sqliter to be a On Android you'd be able to use Long but on native it would just crash: |
What do you mean with Android? The android driver does not support Long too and it also crashes. |
So we only changed it for non android/ios consumers? |
The change affects all targets, but from my view I would use a long version, eg version based on a timestamp, for backend systems. On mobile, you could easily use the build/release number as migration number, which is rarely bigger than Int.max. Also, to get a crash, you need to change your versioning after using sqldelight 2.0.0-rc02. The old behaviour is still working. |
Fixes #4296
Draft because it needs a new sql-psi release (or use snapshot version)