Fixes 4932 postgresql default constraint functions #4934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4932 - compiler error when functions are used as
DEFAULT
column valuesπ Currently the work-around/escape-hatch is to enclose the function in parentheses as this matches the grammar rule
LP expr RP
Add
{function_expr}
to thedefault_constraint
ruleOther consideration is that ideally the function result type must be assignable to the column type π‘ π’ and would need to be compiler checked - currently none of the
DEFAULT
types are checked and can be any type of expression π€π‘ Ideally - SqlDelight would provide error
Postgresql does provide error
error: column "c1" is of type integer but default expression is of type uuid