-
Notifications
You must be signed in to change notification settings - Fork 543
Support wasmJs target #4965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support wasmJs target #4965
Conversation
Is the conversion to |
Sure, I will revert this change |
2c9fe7e
to
5c2d9a3
Compare
@dellisd Hi!
|
fadbd3e
to
9c998de
Compare
@dellisd Hi!
|
0f55176
to
8d53f00
Compare
I'm not sure why, but instrumentation tests are failing on CI. |
Turbine 1.1.0 with wasmJs support is out |
Replaced Turbine snapshot with |
f5f4c46
to
8253cfb
Compare
Currently trying to fix tests 🙂 |
49e197c
to
672ff65
Compare
5ba62bc
to
7e91ea4
Compare
8838b26
to
f3fbc73
Compare
d77a6e1
to
60b384e
Compare
Still any update on the same |
Hi Need to make some changes while adding the lib update pluginManagement {
repositories {
mavenLocal()
google()
gradlePluginPortal()
mavenCentral()
+ maven { url = uri("https://s01.oss.sonatype.org/content/groups/staging") } // <---- add this
}
}
dependencyResolutionManagement {
repositories {
mavenLocal()
google()
mavenCentral()
+ maven { url = uri("https://s01.oss.sonatype.org/content/groups/staging") } // <---- add this
}
} then update only plugin and library group, -id("app.cash.sqldelight") version "2.0.2"
+id("io.telereso.kmp.sqldelight") version "2.1.0-wasm-no-op.4" -implementation("app.cash.sqldelight:sqlite-driver:2.0.2")
+implementation("io.telereso.kmp.sqldelight:sqlite-driver:2.1.0-wasm-no-op.4") No need to update src classes imports My use case that I had 9 project with db I needed to expose to web , I'll try to publish this MR too to see if it works or not , but need some time |
@dellisd any update? |
…her than 23 is required)
…available for androidNative
…eDefaultWebWorkerDriver()`. remove unnecessary `jsCommon` group from web-worker-driver.
…datetime to 0.6.0. remove expect/actual classes warning
04f034d
to
d491021
Compare
Upgraded to latest master, fixed all errors. |
I appreciate the huge amount of enthusiasm around this PR, and I want to say that I'm also very excited about the prospect of using SQLDelight in Wasm projects. I also really appreciate the contributions being made here, but this PR is very difficult to review as-is because of its size and because of all of the changes that aren't directly related to enabling Wasm that are being pulled into here. My recommendation would be to break this PR up into a few smaller PRs that are more focused and will be easier/quicker to review:
Thank you! |
@dellisd Agree, there are lots of changes to just accept , but until it's broken down, can we get snapshot from this PR, |
Sure, I will make those changes it in the next couple of weeks |
@ahna92 you can always publish this branch to your mavenLocal and take a look 🙂 |
I'll be closing this PR in favour of the new ones! |
What's impossible for now:
WebWorkerDriver
can't be done without support for Kotlin arrays interop withwasmJs
: https://youtrack.jetbrains.com/issue/KT-57125/Add-interop-with-JavaScript-arrays-to-Kotlin-WasmChanges:
wasmJs
target inMultiplatformConventions
and:driver-test
.jsCommon
source set containing common code forjs
andwasmJs
targets.jsNativeCommon
source set to:runtime
module containing common code fornative
,js
, andwasmJs
targets.watchosDeviceArm64
andlinuxArm64
because of failing tests.WebWorkerDriver
forwasmJs
target. Fix all tests to be passing.