Consider foreign key table constraints when sorting initialization statements #5325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Jul 1, 2024
sqldelight-compiler/src/main/kotlin/app/cash/sqldelight/core/lang/util/TreeUtil.kt
Outdated
Show resolved
Hide resolved
4dcda7d to
8328695
Compare
|
Thanks! Any idea if there is an issue for this? I did a quick look and didn't see one, but we have a lot... |
|
When searching if this is known, I found #2742 which is very old and already closed after providing a workaround, but related nonetheless. Apart from that, I saw no issues about this problem specifically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, foreign key constraints on the "table level" are not considered when sorting the initialization statements. This PR fixes this.
This is especially annoying because the current behavior does not play nicely with composite foreign keys.