[wasmJs] Enable wasmJs target #5531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dellisd
approved these changes
Oct 29, 2024
| moduleKind.set(JsModuleKind.MODULE_UMD) | ||
| } | ||
| } | ||
|
|
||
| applyDefaultHierarchyTemplate { | ||
| common { | ||
| group("jsCommon") { |
There was a problem hiding this comment.
Suggested change
| group("jsCommon") { | |
| group("web") { |
runtime/build.gradle
Outdated
| @@ -16,6 +16,16 @@ apiValidation { | |||
| } | |||
|
|
|||
| kotlin { | |||
| applyDefaultHierarchyTemplate { | |||
| it.common { | |||
| it.group("jsNativeCommon") { | |||
There was a problem hiding this comment.
Suggested change
| it.group("jsNativeCommon") { | |
| it.group("nonJvm") { |
938bfa7 to
6713b83
Compare
|
Great to see this land! Amazing work Ilya. When can we expect a release with the Wasm support? |
|
@skaldebane this is only 1st PR of 3 🙂 |
|
Is there a snapshot available with this merged PR? I cannot find the latest snapshots anywhere. |
|
@Thomas-Vos here's a snapshot by @ahna92 in my another PR but you will need PAT to access it #5534 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable wasmJs target
This PR adds support for the WebAssembly JavaScript (wasmJs) target in SQLDelight.
Changes
Build Configuration
wasmJs()target alongside existingjs()target in multiplatform conventionsjsCommongroup that contains both JS and WasmJS targetsSource Reorganization
CurrentThreadId.ktin:runtimefromjsMaintojsCommonMainto share between JS and WasmJSCloseable.ktfromjsMainandnativeMainintojsNativeCommonMainto share between JS, WasmJS, and Native targets.