-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
attempt at adding decimal #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hopefully a passable attempt to add decimal support per sqlitebrowser#373 (comment) I re-organized the conversion list, too.
Hmmm, that's breaking the build. Are you ok to click on "Details" to check the error, and attempt to fix it? π |
@jungle-boogie Sorry, didn't notice you've pushed a fix. Just tested it quickly here, and it looks (mostly) good. π There is one bit I'm unsure of though. For decimal display, it's using "0x" as the prefix. eg "0x10". Isn't "0x" normally used to indicate a hexadecimal number? |
%d is decimal! I won't forget this now.
%d is decimal! |
Awesome! Testing now. π |
Yep, that looks good now. Thanks @jungle-boogie. π |
Yes, this is looking fine π Thanks for your contribution! |
@MKleusberg - just as a heads up while on the topic... the format definition box itself doesn't seem to be editable for the "custom" type. eg people can't type in their own format and have it stick. Is that supposed to work? π |
I'm not sure to be honest ^^ But the code looks like this was never supposed to work. Allowing to type in one's own display formats isn't as easy as it sounds either, because we'd had to add some extra error checking. With the current code I see two problems:
So, yes, we can get this done. But it's a bit trickier than expected. I'll just open a new issue for now so we can keep this in mind π |
Cool. π |
hopefully a passable attempt to add decimal support per
#373 (comment)
I re-organized the conversion list, too.