Rationalise the Edit Cell dock and Windows code into one #668
Conversation
Prior to this PR, we've had the Edit Cell be available both in a "dock" and "window" mode. Both at the same time. (!) The "dock" mode already had tear off window functionality and was more complete, whereas the "window" mode was buggy and didn't really add anything new. This PR removes the "window" version of the dock, and cleans up the handling of "dock" mode, so there's just one Edit Cell dock now. It can be torn off and used as a window, docked to the main UI (by double clicking its title bar), and toggled on/off with Ctrl-E (Cmd-E on OSX).
|
Tried this out on Win 8.1. Not a success.
I'll put more time into this tomorrow, to (hopefully) solve those problems. 😄 |
|
On the plus side, the window state (eg DB Toolbar, Plot, DB Schema, Edit dock) is kept and restored correctly between sessions, even on Windows. 😄 |
|
Found the solution to both problems on Windows. 😄
So, no code change needed. 😄 |
|
@justinclift, Directly typing when a cell is selected works on OS X too. |
|
Cool. 😄 |
|
@revolter Btw, really hoping/expecting the Edit Cell still "just works" for you from here on. If anything seems wrong with it, let me know (if/when you get a chance). 😄 |
|
I can't build the latest master, this is the last day (hours) I can test, so if you want me to test a little bit the latest master, please send me a build 😄 |
|
Sure, will build one now. 😄 |
|
Not good. I crashed it following these steps: • Extract app from dmg Also, I find it odd that it is now showing up at first run. |
|
Another thing I find odd is that following these steps: • Select hides the docked editor. |
|
But I LOVE that now, hitting the |
|
k, will definitely check out the crash. That obviously needs hunting down and killing with fire. 😀 For the "find it odd that it is showing up at first run"... yeah, I removed the hide() call from the edit dock startup. The edit dock can be toggled on/off with Cmd-E, and it keeps state between sessions. So in theory, if you have it turned off when you quit the program, it should be turned off when you start the program up next. I think that's an improvement, but if it turns out not to be... then sure, the hide() call can be reintroduced. 😉 |
|
Hmmm, I'll look into the clicking of OK closing the docked editor. Hadn't thought of that. Oops. 😉 |
I understand this, but previously, IIRC, on the very first open after installing, it didn't show up. So I was just pointing out that this behavior changed in the latest master. Other than that, it's working great! 👍
Maybe it should close only if it's not docked in the main window. |
|
That sounds like a decent approach. 😄 |
|
... and it turns out Ctrl-E is already a key binding we use, for "Execute current line" in the Execute SQL window. Any suggestions on better key combo for use? 😄 |
|
@revolter Just added a commit which stops the OK button from closing the Edit Dock. It doesn't close it for either docked nor undocked mode now. Seems ok to me this way, but yeah... lets get some feedback. Still need to investigate the crash bug, and the bug with in-place updated values not being put into the edit dock. Won't be tonight though. Mentally wiped out atm. 😑 |
|
Hmmm... those OK/Cancel buttons could probably be changed into a single "Update" button now. Will think it over... 😄 |
|
And the buttons combining idea sounds good to me. |
Prior to this PR, we've had the Edit Cell be available both in a "dock"
and "window" mode. Both at the same time. (!)
The "dock" mode already had tear off window functionality and was more
complete, whereas the "window" mode was buggy and didn't really add
anything new.
This PR removes the "window" version of the dock, and cleans up the
handling of "dock" mode, so there's just one Edit Cell dock now. It
can be torn off and used as a window, docked to the main UI (by double
clicking its title bar), and toggled on/off with Ctrl-E (Cmd-E on OSX).