Improved copy/pasting in ExtendedTableWidget #709

vtronko · 2016-08-05T21:39:35Z

NULLs are now copied and pasted correctly
Ctrl+C allows only rectangular selections (multi-selections should be provided later with Ctrl+Shift+C and not use clipboard)

Testing is much appreciated.

NB. return in 199L is workaround, because of mess with keyPressEvent in 226L.

revolter · 2016-08-06T09:40:58Z

Should it work for BLOBs too? Also, I found a problem, but can't easily reproduce. I had a database which got corrupted because of #674, and had the content

"�PNG
�
"

upon copying it and trying to paste in a cell, it pastes "�PNG and " in the cell beneath it, even though I copied only one cell.

Running sqlite3 db.sqlite "SELECT column2 FROM table WHERE column1 = '1';" | hexdump -c gives me:

0000000   �   �   �   P   N   G  \r  \n 032  \n  \n
000000b

and I believe the \r is the problem, but I can't manage to type that character manually on OS X.

The same thing happens when trying to copy and paste a non-corrupted BLOB, so maybe we should disable copying (temporarily?) BLOBs.

Running sqlite3 db.sqlite "SELECT column2 FROM table WHERE column1 = '1';" | hexdump -C gives me:

00000000  ef bf bd 50 4e 47 0d 0a  1a 0a 0a                 |...PNG.....|
0000000b

if it is of any help.

revolter · 2016-08-06T10:12:20Z

Finally reproduced it using (while learning) the hex editor.

select a cell
switch to Binary mode in the edit dock
type 31 0d 0a 1a 32
copy & paste the cell

and it will paste "1 in the target cell and �2" (1a 32 22, where1ais\r`) in the cell beneath it.

justinclift · 2016-08-06T13:27:28Z

Excellent @innermous, this looks like a good start to improving the Copy/Paste code. 👍

The new warning message about "This function cannot be used with multiple selections." is a decent idea. Maybe add the word "independent" to it though? eg "... with multiple independent selections."

Without that, it could be kind of confusing. Some people might misunderstand it to mean "multiple cells selected".
The code in this PR is making progress towards better BLOB handing too. Prior to this PR, binary data ("BLOBS") would just copy the text string "BLOB" to a target cell. With this PR, at least it's attempting to copy the actual data. 😁

The copy itself doesn't seem binary safe though, as @revolter mentioned above. In testing here, it's converting image blobs to corrupted text (eg "PNG") and also corrupting the cell below it.

The screenshots below should illustrate.

vtronko · 2016-08-06T14:42:52Z

Wait, copying blobs works without my commit?

IIRC it just copied "BLOB" text as is.

revolter · 2016-08-06T15:06:12Z

@innermous, That's what @justinclift said:

Prior to this PR, binary data ("BLOBS") would just copy the text string "BLOB" to a target cell.

justinclift · 2016-08-06T15:06:20Z

Yeah, without this PR it just copies the text "BLOB" without the real data. 😉

justinclift · 2016-08-06T19:24:49Z

src/ExtendedTableWidget.cpp

+        // Copy selected data into inner buffer
+        int columns = indices.last().column() - indices.first().column() + 1;
+        while (!indices.isEmpty()) {
+            QByteArrayList lst;


Seems to need an #include <QByteArrayList> up top, as Travis is complaining.

Never mind, it'll all be fixed.
It's not even ready.

I am astonished though, why my build didn't fail.

Well, I got it.
They don't have QByteArrayList in Qt4. Another QByteArrayList in SQLiteBrowser code is just typedef.
You still think we shouldn't move to Qt5?

vtronko · 2016-08-07T01:46:38Z

I don't get it.
I included , but it's still mad.

justinclift · 2016-08-07T03:24:51Z

Yeah, we definitely can't move to Qt5 yet. 😦

I'll build our OSX packages for 3.9.0 with Qt4 again for this release. If they work ok for people, and we don't get crash reports (like last time, with 3.8.0), we can probably move to Qt5 only. 😄

revolter · 2016-08-07T08:15:55Z

Looking good. BLOBs are working now, but this still corrupts the cell beneath the target cell.

vtronko · 2016-08-07T16:05:09Z

@revolter I don't know how come it got corrupted for you, since multi-blob data is managed via inner buffer.

justinclift · 2016-08-07T16:41:21Z

Hmmm, I broke the "Apply" button in the Edit Cell with yesterday's change. 😦

I need to fix that first, in order to test some stuff properly.

Looking at it now. 😄

revolter · 2016-08-07T17:35:42Z

@innermous, I already explained it, please read again. It's not about copying multiple cells.

justinclift · 2016-08-08T18:08:48Z

Closed?

vtronko · 2016-08-08T20:04:00Z

@justinclift I don't know how to implement multilines correctly.
Maybe in future I'll figure out but for now I'll freeze the branch.

revolter · 2016-08-08T21:11:51Z

@innermous, Didn't you say that the multiline problem existed prior to this PR? I think that this adds useful fixed like copying BLOBs correctly.

justinclift · 2016-08-08T21:30:32Z

Thinking about it, @revolter is correct. This PR fixes some of the existing broken behaviour (binary/image copying internally), without introducing new bugs.

It's not a "perfect" solution, but it's better than the code we have. Are you ok with it being merged anyway? 😄

vtronko · 2016-08-09T04:10:16Z

Resuming work.
@justinclift I am not okay with half-measures. What should be done should be done.

justinclift · 2016-08-09T09:13:35Z

@innermous Ok. 😄

An idea for this popped into my head last night.

For the internal copy-paste operation, would it be possible to treat text type cells as binary?

eg:

isBinary() continues to put text data on the clipboard for sharing-between-applications
text data is also added to m_buffer (maybe as QByteArray too?)
for paste operation, m_buffer is used unless external data has been added to clipboard. (for example, someone does Copy in text editor then Paste in DB4S)

Detecting external copy to clipboard can probably be done using checksum created for Copy operation, and maybe kept in a class variable.

justinclift · 2016-08-11T13:28:39Z

src/ExtendedTableWidget.cpp

+    }
+
+    // Check whether selection is rectangular
+    QItemSelection rect(indices.first(), indices.last());


Would setting QAbstractItemView::ContiguousSelection instead, to force a single continuous selection, be better?

If we are not implementing multi-selections copy then you can force rectangular selection.

vtronko · 2016-08-12T03:24:00Z

Moved to google docs format.
I need to test it on windows first, it has some dibs with carriage return.

vtronko · 2016-08-12T05:21:44Z

Feeling sorry for your travis.
Adding some windows-specific changes required to go deep in history :)

This is working as a charm now.

justinclift · 2016-08-12T10:12:50Z

Thanks @innermous, that's awesome! 😄

justinclift · 2016-08-12T11:44:47Z

Testing this out now on OSX, it seems pretty good.

Copying & pasting BLOB data works properly, as does multi-line text, as does cut-n-paste to external applications.

I'm going to cherry-pick this into the 3.9.x branch too. 😉

Improved copy/pasting in ExtendedTableWidget

justinclift added the enhancement Feature requests. label Aug 6, 2016

justinclift added this to the 3.9.0 - Something Nifty Treads Here Lightly milestone Aug 6, 2016

justinclift assigned vtronko Aug 6, 2016

vtronko force-pushed the copypaste-reimplement branch from f350ff3 to e69117f Compare August 6, 2016 15:05

vtronko force-pushed the copypaste-reimplement branch from e69117f to a514123 Compare August 6, 2016 15:34

justinclift reviewed Aug 6, 2016
View reviewed changes

vtronko force-pushed the copypaste-reimplement branch from 9b9fb51 to 69b6661 Compare August 7, 2016 01:19

vtronko force-pushed the copypaste-reimplement branch from 69b6661 to af1e057 Compare August 7, 2016 02:12

vtronko added 2 commits August 7, 2016 06:01

Improved copy/pasting in ExtendedTableWidget

83e9e60

Implemented multiple BLOB cells copy/paste

5cd65e8

Implement copy/pasting single image via clipboard

043dee0

vtronko force-pushed the copypaste-reimplement branch from af1e057 to 043dee0 Compare August 7, 2016 15:23

vtronko closed this Aug 8, 2016

vtronko reopened this Aug 9, 2016

justinclift reviewed Aug 11, 2016
View reviewed changes

vtronko force-pushed the copypaste-reimplement branch from b0da5c8 to 166efc9 Compare August 12, 2016 05:04

vtronko added 2 commits August 12, 2016 08:16

Implement persistent clipboard copy/paste formatting

d12fd1b

Force contiguous selection in ExtendedTableWidget

e607b88

vtronko force-pushed the copypaste-reimplement branch from 09191a1 to e607b88 Compare August 12, 2016 05:21

vtronko merged commit 8cbd7e5 into sqlitebrowser:master Aug 12, 2016

revolter mentioned this pull request Aug 12, 2016

Unicode text in BLOB not copying for other aplications #724

Closed

13 tasks

justinclift modified the milestones: 3.10.0 - A Rubber Cactus Has Many Uses, 3.9.0 - Something Nifty Treads Here Lightly Aug 12, 2016

justinclift modified the milestones: 3.9.0 - Something Nifty Treads Here Lightly, 3.10.0 - A Rubber Cactus Has Many Uses Aug 12, 2016

vtronko added a commit that referenced this pull request Dec 29, 2016

Merge pull request #709 from innermous/copypaste-reimplement

fd25bca

Improved copy/pasting in ExtendedTableWidget

justinclift mentioned this pull request May 26, 2017

Modify multiple cells' values at the same time #1022

Closed

13 tasks

Uh oh!

Improved copy/pasting in ExtendedTableWidget #709

Improved copy/pasting in ExtendedTableWidget #709

Uh oh!

Conversation

vtronko commented Aug 5, 2016

Uh oh!

revolter commented Aug 6, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

revolter commented Aug 6, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinclift commented Aug 6, 2016

Uh oh!

vtronko commented Aug 6, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

revolter commented Aug 6, 2016

Uh oh!

justinclift commented Aug 6, 2016

Uh oh!

justinclift Aug 6, 2016

Choose a reason for hiding this comment

Uh oh!

vtronko Aug 6, 2016

Choose a reason for hiding this comment

Uh oh!

vtronko Aug 7, 2016

Choose a reason for hiding this comment

Uh oh!

vtronko commented Aug 7, 2016

Uh oh!

justinclift commented Aug 7, 2016

Uh oh!

revolter commented Aug 7, 2016

Uh oh!

vtronko commented Aug 7, 2016

Uh oh!

justinclift commented Aug 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

revolter commented Aug 7, 2016

Uh oh!

justinclift commented Aug 8, 2016

Uh oh!

vtronko commented Aug 8, 2016

Uh oh!

revolter commented Aug 8, 2016

Uh oh!

justinclift commented Aug 8, 2016

Uh oh!

vtronko commented Aug 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinclift commented Aug 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinclift Aug 11, 2016

Choose a reason for hiding this comment

Uh oh!

vtronko Aug 12, 2016

Choose a reason for hiding this comment

Uh oh!

vtronko commented Aug 12, 2016

Uh oh!

vtronko commented Aug 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinclift commented Aug 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinclift commented Aug 12, 2016

Uh oh!

Uh oh!

revolter commented Aug 6, 2016 •

edited

Loading

revolter commented Aug 6, 2016 •

edited

Loading

vtronko commented Aug 6, 2016 •

edited

Loading

justinclift commented Aug 7, 2016 •

edited

Loading

vtronko commented Aug 9, 2016 •

edited

Loading

justinclift commented Aug 9, 2016 •

edited

Loading

vtronko commented Aug 12, 2016 •

edited

Loading

justinclift commented Aug 12, 2016 •

edited

Loading