Fix uninitialized value memory error #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While profiling using Valgrind, two uninitialized value errors popped up, because the dataSource iVar was used in the if check from the editTextChanged function before initializing it. This commit moves the dataSource initializations before any other calls.
revolter
commented
Oct 1, 2016
| @@ -94,38 +94,44 @@ void EditDialog::loadData(const QByteArray& data) | |||
| case Null: | |||
| switch (editMode) { | |||
| case TextEditor: | |||
| // The text widget buffer is now the main data source | |||
| dataSource = TextBuffer; | |||
|
|
|||
| // Empty the text editor contents, then enable text editing | |||
| ui->editorText->clear(); | |||
| ui->editorText->setEnabled(true); | |||
There was a problem hiding this comment.
This caused the error, as it indirectly calls the editTextChanged function, but changed all of them as it's safer.
|
Tested this on my OSX desktop. Doesn't seem to have any weird side effects, so going to merge it. 😄 |
vtronko
pushed a commit
that referenced
this pull request
Dec 29, 2016
While profiling using Valgrind, two uninitialized value errors popped up, because the dataSource iVar was used in the if check from the editTextChanged function before initializing it. This commit moves the dataSource initializations before any other calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While profiling using Valgrind, two uninitialized value errors popped up,
because the dataSource iVar was used in the if check from the editTextChanged
function before initializing it. This commit moves the dataSource
initializations before any other calls.
@sqlitebrowser/developers, Do you think this can cause other problems?