Corrects some typos and tildes #924
Conversation
|
Awesome @lulol! Are these ok to merge as is, or should we take screenshots of them in action first, or ? 😄 |
There was a problem hiding this comment.
I've added one comment to this PR but other than that this looks good to me.
@justinclift Probably no need for screenshots I guess, but I'll let @lulol decide 😃
@lulol Thanks a lot for the work you've put into this 👍
| @@ -2333,7 +2333,7 @@ Do you want to insert it anyway?</source> | |||
| </message> | |||
| <message> | |||
| <location filename="../MainWindow.ui" line="1891"/> | |||
| <source>Copy the CREATE statement of the item to the clipboard</source> | |||
| <source>Copy the CREATE statement of the ítem to the clipboard</source> | |||
There was a problem hiding this comment.
Not sure here because this changes the source string (= the original English text), not the Spanish one.
There was a problem hiding this comment.
@MKleusberg Ooops. 😢 Fixed.
@justinclift Now think that are ok to merge as is.
Although for some couldn't find the dialogs where are actually being used, these are just fixed typos. All of them hopefully.
But in the GUI I'm still seeing those same untranslated strings that seemed to be translated in the .ts like that in line="14" and line="1309" but the others are not even defined there.
There was a problem hiding this comment.
@lulol Interesting. Some of those I was able to find using grep:
Main window
Preferences pialog
Does that help? 😄
|
Thanks, @lulol 👍 I think, in order to have those missing strings included in the translation file, you'll need to re-run Qt Linguist on the application. Unfortunately I have no experience with that whatsoever... |
|
Ahhh, I can do that and commit the results if it would help. @lulol ? |
|
@MKleusberg It can be done from Qt Creator. Tools → External → Linguist → Update translations (lupdate) |
|
@justinclift We could try and see how it works out in the next nightly build. |
|
@justinclift I see that now among the 55 strings tagged "unfinished" are those that previously were missing in the .ts. Should I translate them now? So that we can check before changing them for all the languages, if in the next nightly build also the other strings already translated but not showing in the GUI like "Edit Database Cell" and "DB Schema" are also fixed. |
|
Sure, if you want. 😄 |
|
@justinclift Done, and PR ready. Hope that it works and the new generated files finally fix the missing translations for all the languages. 😄 |
|
Excellent @lulol, that was very quick! I needed to get sleep, so missed getting the PR merged right away (now done). |
Corrects some typos and tildes since the latest update. 😄